Ignore untrusted workspace error for telemetry #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
vscode
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Feb 5, 2025
Merge activity
|
andyw8
approved these changes
Feb 5, 2025
### Motivation In efforts to make our telemetry as useful as possible, I think we should ignore errors that we cannot recover from. When the version manager is Shadowenv and the current workspace is untrusted, there's nothing we can do. Auto-trusting a workspace is a security issue because it would execute arbitrary Shadow Lisp files, so that's not an option. Since only the user can decide to trust a workspace, there really is nothing we can do if they dismissed our offer to trust it. ### Implementation Started ignoring untrusted workspace errors for telemetry. Also, added the workspace name as an attribute, which is useful when trying to discover specific types of errors. ### Automated Tests Added a test.
graphite-app
bot
force-pushed
the
02-05-ignore_untrusted_workspace_error_for_telemetry
branch
from
96c54cf to
65a8193
Compare
graphite-app
bot
deleted the
02-05-ignore_untrusted_workspace_error_for_telemetry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In efforts to make our telemetry as useful as possible, I think we should ignore errors that we cannot recover from. When the version manager is Shadowenv and the current workspace is untrusted, there's nothing we can do.
Auto-trusting a workspace is a security issue because it would execute arbitrary Shadow Lisp files, so that's not an option.
Since only the user can decide to trust a workspace, there really is nothing we can do if they dismissed our offer to trust it.
Implementation
Started ignoring untrusted workspace errors for telemetry. Also, added the workspace name as an attribute, which is useful when trying to discover specific types of errors.
Automated Tests
Added a test.