Handle invalid URIs in magic source links #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Feb 3, 2025
vinistock
force-pushed
the
02-03-handle_invalid_uris_in_magic_source_links
branch
from
19cdf67 to
9c79796
Compare
Merge activity
|
### Motivation Another error caught by telemetry. If the magic source link is written manually, the user may enter something that's not a valid URI and that crashes the document link request. ### Implementation Started handling the URI parsing errors so that we simply don't do anything if it's not a valid URI. ### Automated Tests Added a test that reproduces the behaviour.
graphite-app
bot
force-pushed
the
02-03-handle_invalid_uris_in_magic_source_links
branch
from
9c79796 to
1d0d3d4
Compare
graphite-app
bot
deleted the
02-03-handle_invalid_uris_in_magic_source_links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Another error caught by telemetry. If the magic source link is written manually, the user may enter something that's not a valid URI and that crashes the document link request.
Implementation
Started handling the URI parsing errors so that we simply don't do anything if it's not a valid URI.
Automated Tests
Added a test that reproduces the behaviour.