Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @shopify/eslint-plugin from 46.0.0 to 47.0.1 in /vscode #3130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 3, 2025

Bumps @shopify/eslint-plugin from 46.0.0 to 47.0.1.

Release notes

Sourced from @​shopify/eslint-plugin's releases.

@​shopify/eslint-plugin@​47.0.1

Patch Changes

  • #461 b1b449c Thanks @​BPScott! - Add @typescript-eslint/no-unused-expressions to typescript ruleset

    In v46 in, we enabled no-unused-expressions in the core js config, then disabled it and replaced it with @babel/no-unused-expressions in esnext config. In typescript files we turn off no-unused-expressions but left @babel/no-unused-expressions enabled - which seems like an oversight given that @typescript-eslint/no-unused-expressions existed. In v47.0.0 we removed configuration of @babel/no-unused-expressions entirely, which meant that there was no linting of unused-expressions. This change brings back unused expression linting to typescript files.

@​shopify/eslint-plugin@​47.0.0

Major Changes

  • #444 75fe8da Thanks @​BPScott! - Replace eslint-plugin-node with eslint-plugin-n

  • #445 f1e02bc Thanks @​BPScott! - Update plugin dependencies

    • eslint-plugin-import: ^2.29.0to ^2.31.0
    • eslint-plugin-jest: ^28.5.0to ^28.9.0
    • eslint-plugin-jsx-a11y: 6.8.0 to 6.10.2
    • eslint-plugin-prettier: ^5.1.3to^5.2.1
    • eslint-plugin-promise: ^6.1.1to^7.2.1
    • eslint-plugin-react: ^7.34.1to^7.37.2
    • eslint-plugin-react-hooks: ^4.6.2to^5.1.0
    • eslint-plugin-sort-class-members: ^1.20.0 to ^1.21.0
  • #457 ef24642 Thanks @​BPScott! - Update typescript-eslint from ^7.9.0 to ^8.18.0. Replace usage of the @typescript-eslint/eslint-plugin and @typescript-eslint/eslint-parser packages with using the new typescript-eslint package. See migration information at https://typescript-eslint.io/blog/announcing-typescript-eslint-v8.

    The @typescript-eslint/ban-types rule has been removed and replaced with @typescript-eslint/no-empty-object-type and @typescript-eslint/no-wrapper-object-types. @typescript-eslint/no-require-imports is now enabled.

  • #455 e347da8 Thanks @​BPScott! - Remove configuration of deprecated formatting rules.

    Per https://eslint.org/blog/2023/10/deprecating-formatting-rules/ and https://typescript-eslint.io/blog/deprecating-formatting-rules several formatting related rules have been deprecated from eslint core and typescript-eslint and moved into @stylistic/eslint-plugin. These rules are removed in typescript-eslint v8 (released) and probably eslint v10 (unreleased).

    To prepare for future updates we are removing our configuration of these rules. We recommend that you use Prettier (https://prettier.io/) for formatting considerations - either by running it in parallel with ESLint or as part of ESLint through using eslint-plugin-prettier via the prettier config provided by @shopify/eslint-plugin. If you do not wish to use Prettier, then we suggest you configure rules from @stylistic/eslint-plugin (https://eslint.style/packages/default).

    Note that if you already use the prettier config then this removal will have no effect as all these rules were already turned off.

    Configuration for the following rules in the es5, esnext and typescript configs have been removed:

    From typescript-eslint:

    • @​typescript-eslint/brace-style
    • @​typescript-eslint/func-call-spacing
    • @​typescript-eslint/indent
    • @​typescript-eslint/keyword-spacing
    • @​typescript-eslint/member-delimiter-style
    • @​typescript-eslint/no-extra-parens
    • @​typescript-eslint/quotes
    • @​typescript-eslint/semi
    • @​typescript-eslint/space-infix-ops
    • @​typescript-eslint/type-annotation-spacing

... (truncated)

Changelog

Sourced from @​shopify/eslint-plugin's changelog.

47.0.1

Patch Changes

  • #461 b1b449c Thanks @​BPScott! - Add @typescript-eslint/no-unused-expressions to typescript ruleset

    In v46 in, we enabled no-unused-expressions in the core js config, then disabled it and replaced it with @babel/no-unused-expressions in esnext config. In typescript files we turn off no-unused-expressions but left @babel/no-unused-expressions enabled - which seems like an oversight given that @typescript-eslint/no-unused-expressions existed. In v47.0.0 we removed configuration of @babel/no-unused-expressions entirely, which meant that there was no linting of unused-expressions. This change brings back unused expression linting to typescript files.

47.0.0

Major Changes

  • #444 75fe8da Thanks @​BPScott! - Replace eslint-plugin-node with eslint-plugin-n

  • #445 f1e02bc Thanks @​BPScott! - Update plugin dependencies

    • eslint-plugin-import: ^2.29.0to ^2.31.0
    • eslint-plugin-jest: ^28.5.0to ^28.9.0
    • eslint-plugin-jsx-a11y: 6.8.0 to 6.10.2
    • eslint-plugin-prettier: ^5.1.3to^5.2.1
    • eslint-plugin-promise: ^6.1.1to^7.2.1
    • eslint-plugin-react: ^7.34.1to^7.37.2
    • eslint-plugin-react-hooks: ^4.6.2to^5.1.0
    • eslint-plugin-sort-class-members: ^1.20.0 to ^1.21.0
  • #457 ef24642 Thanks @​BPScott! - Update typescript-eslint from ^7.9.0 to ^8.18.0. Replace usage of the @typescript-eslint/eslint-plugin and @typescript-eslint/eslint-parser packages with using the new typescript-eslint package. See migration information at https://typescript-eslint.io/blog/announcing-typescript-eslint-v8.

    The @typescript-eslint/ban-types rule has been removed and replaced with @typescript-eslint/no-empty-object-type and @typescript-eslint/no-wrapper-object-types. @typescript-eslint/no-require-imports is now enabled.

  • #455 e347da8 Thanks @​BPScott! - Remove configuration of deprecated formatting rules.

    Per https://eslint.org/blog/2023/10/deprecating-formatting-rules/ and https://typescript-eslint.io/blog/deprecating-formatting-rules several formatting related rules have been deprecated from eslint core and typescript-eslint and moved into @stylistic/eslint-plugin. These rules are removed in typescript-eslint v8 (released) and probably eslint v10 (unreleased).

    To prepare for future updates we are removing our configuration of these rules. We recommend that you use Prettier (https://prettier.io/) for formatting considerations - either by running it in parallel with ESLint or as part of ESLint through using eslint-plugin-prettier via the prettier config provided by @shopify/eslint-plugin. If you do not wish to use Prettier, then we suggest you configure rules from @stylistic/eslint-plugin (https://eslint.style/packages/default).

    Note that if you already use the prettier config then this removal will have no effect as all these rules were already turned off.

    Configuration for the following rules in the es5, esnext and typescript configs have been removed:

    From typescript-eslint:

    • @​typescript-eslint/brace-style
    • @​typescript-eslint/func-call-spacing
    • @​typescript-eslint/indent
    • @​typescript-eslint/keyword-spacing
    • @​typescript-eslint/member-delimiter-style
    • @​typescript-eslint/no-extra-parens
    • @​typescript-eslint/quotes
    • @​typescript-eslint/semi
    • @​typescript-eslint/space-infix-ops

... (truncated)

Commits
  • d69470f Version Packages (#462)
  • b1b449c Return no-unused-expressions linting in typescript files (#461)
  • 039e352 Version Packages (#443)
  • 108c1cd Fix prefer-module-scope-constants in commonjs files (#460)
  • ef24642 Update typescript-eslint to v8 (#457)
  • 45d2acd Make no-namespace-imports test a real test (#459)
  • 421b2b9 Move jest, typescript and webpack rules into base rules folders (#458)
  • e347da8 Remove configuring deprecated formatting rules (#455)
  • 4cfd24c Stop disabling rules now that their babel counterparts are removed (#454)
  • a38a7ea Update usage of deprecated superTypeParameters (#453)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@shopify/eslint-plugin](https://github.com/Shopify/web-configs/tree/HEAD/packages/eslint-plugin) from 46.0.0 to 47.0.1.
- [Release notes](https://github.com/Shopify/web-configs/releases)
- [Changelog](https://github.com/Shopify/web-configs/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/Shopify/web-configs/commits/@shopify/eslint-plugin@47.0.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@shopify/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner February 3, 2025 03:02
@dependabot dependabot bot added dependencies dependencies javascript Pull requests that update Javascript code labels Feb 3, 2025
@dependabot dependabot bot requested review from a team, egiurleo and vinistock February 3, 2025 03:02
Copy link

graphite-app bot commented Feb 3, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants