Prefer exact matches when guessing types #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Jan 30, 2025
Merge activity
|
### Motivation I noticed we weren't guessing the correct types even in situations where I expected us to. The issue turns out to be not preferring exact matches. For example, where `type` is used in the LSP itself, we ended up guessing `ParseResultType` from Prism because that was the first constant ending with `Type` that we found. I think we can improve our accuracy by preferring exact matches over partial ones. ### Implementation Started looking for exact matches first, falling back to our original partial matches. ### Automated Tests Added a test that reproduces the scenario.
vinistock
force-pushed
the
01-30-prefer_exact_matches_when_guessing_types
branch
from
cf8adb2 to
56aa676
Compare
graphite-app
bot
deleted the
01-30-prefer_exact_matches_when_guessing_types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed we weren't guessing the correct types even in situations where I expected us to. The issue turns out to be not preferring exact matches.
For example, where
typeis used in the LSP itself, we ended up guessingParseResultTypefrom Prism because that was the first constant ending withTypethat we found.I think we can improve our accuracy by preferring exact matches over partial ones.
Implementation
Started looking for exact matches first, falling back to our original partial matches.
Automated Tests
Added a test that reproduces the scenario.