Avoid failing if file is quickly created and deleted #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
vinistock
force-pushed
the
01-28-avoid_failing_if_file_is_quickly_created_and_deleted
branch
from
cbce038 to
85a145c
Compare
alexcrocha
approved these changes
Jan 29, 2025
Merge activity
|
### Motivation I noticed that we were crashing if a file was quickly created and deleted. Before we got to processing the created notification, the file would already no longer be there and trying to read from disk would raise. This can happen when running tests that automatically created/delete files or if switching branches quickly. ### Implementation Just started rescuing `Errno::ENOENT`. If the file is no longer there, it probably means we just haven't processed its deleted notification. ### Automated Tests Added a test that fails before the fix.
vinistock
force-pushed
the
01-28-avoid_failing_if_file_is_quickly_created_and_deleted
branch
from
85a145c to
9f0f8f2
Compare
andyw8
approved these changes
Jan 29, 2025
graphite-app
bot
removed
the
graphite-merge
graphite-app
bot
deleted the
01-28-avoid_failing_if_file_is_quickly_created_and_deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that we were crashing if a file was quickly created and deleted. Before we got to processing the created notification, the file would already no longer be there and trying to read from disk would raise.
This can happen when running tests that automatically created/delete files or if switching branches quickly.
Implementation
Just started rescuing
Errno::ENOENT. If the file is no longer there, it probably means we just haven't processed its deleted notification.Automated Tests
Added a test that fails before the fix.