Fix file paths for exec launcher on Windows #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
vinistock
force-pushed
the
01-16-fix_file_paths_for_exec_launcher_on_windows
branch
22 times, most recently
from
de6ec13 to
504d98e
Compare
This was referenced Jan 23, 2025
vinistock
force-pushed
the
01-16-fix_file_paths_for_exec_launcher_on_windows
branch
10 times, most recently
from
72e94e8 to
e584ec7
Compare
andyw8
approved these changes
Jan 28, 2025
vinistock
force-pushed
the
01-16-fix_file_paths_for_exec_launcher_on_windows
branch
from
e584ec7 to
50af30c
Compare
Merge activity
|
vinistock
force-pushed
the
01-16-fix_file_paths_for_exec_launcher_on_windows
branch
from
50af30c to
64aaa57
Compare
### Motivation We were using `exec` incorrectly, which was causing an invalid argument error coming from the system. ### Implementation The correct usage of `exec` is to pass each argument separately. ### Automated Tests I added a new launch integration test, which would've surfaced this issue before to us. Additionally, I made some adjustments to existing tests.
vinistock
force-pushed
the
01-16-fix_file_paths_for_exec_launcher_on_windows
branch
from
64aaa57 to
ed15491
Compare
graphite-app
bot
deleted the
01-16-fix_file_paths_for_exec_launcher_on_windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We were using
execincorrectly, which was causing an invalid argument error coming from the system.Implementation
The correct usage of
execis to pass each argument separately.Automated Tests
I added a new launch integration test, which would've surfaced this issue before to us. Additionally, I made some adjustments to existing tests.