Fix singleton indexing under compact namespaces #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
Graphite App
1 task
andyw8
approved these changes
Jan 14, 2025
vinistock
deleted the
01-14-fix_singleton_indexing_under_compact_namespaces
branch
|
Thanks for making this @vinistock! When might I expect to see this in a release? |
|
We cut releases pretty often. I have a few bug fix PRs up that I'd like to include and then we can ship. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes one of the bugs reported in #3050
We were assigning incorrect names to singleton classes defined inside compact namespaces. The issue is that we were simply taking the last entry in the stack, but when using compact namespaces that entry may include multiple names.
Implementation
Started ensuring we use only the last part of the name to define the singleton.
I also noticed that we were pushing and popping from the name stack when entering a singleton method defined with
def self.foo. That's actually unnecessary. The name stack is only used for constants and inside a method definition we'll only find instance variables (which use the owner stack rather than the name stack).I removed the pushing and popping in that case.
Automated Tests
Added a test.