Use top level namespace operand on Rubocop (#3044) #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
approved these changes
Jan 10, 2025
st0012
added
the
server
|
@st0012. Glad I could help. I have signed the CLA. |
vinistock
approved these changes
Jan 10, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #3044 caused by
rubocop1.70+ that adds the moduleRubyLsp::Rubocop(link).Implementation
Basically make sure to use the top level namespace operand when using Rubocop classes within the namespace
RubyLsp.So
RuboCop::Copfor example is now replaced by::RuboCop::Cop.Automated Tests
No tests are required for this PR.
Manual Tests