Ensure default gem path is also in document selector #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
vinistock
force-pushed
the
vs-ensure-default-gem-path-is-in-selector
branch
from
8eb9f41 to
30fbcbc
Compare
andyw8
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See #2709 (comment)
The default gem path is
~/rubies/3.3.1/lib/ruby/gems/3.3.0. We were correcting this to be~/rubies/3.3.1/lib/ruby/3.3.0because that's where default gems are installed.However, some version managers still install gems under the non corrected path
~/rubies/3.3.1/lib/ruby/gems/3.3.0.Implementation
We need to include both paths in the document selector. The normal path will account for version managers that install gems under the default directory and the corrected one will guarantee we handle requests for default gems.