Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore, if given path is directory while referencing and renaming #2716

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Ignore, if given path is directory while referencing and renaming #2716

merged 1 commit into from
Oct 15, 2024

Conversation

rogancodes
Copy link
Contributor

Motivation

Fixes #2687

@rogancodes rogancodes requested a review from a team as a code owner October 12, 2024 13:46
@rogancodes
Copy link
Contributor Author

I have signed the CLA

@vinistock vinistock added bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes labels Oct 15, 2024
vinistock
vinistock approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@vinistock vinistock merged commit 2277709 into Shopify:main Oct 15, 2024
20 checks passed
@rogancodes rogancodes deleted the fix/ignore-directory-name-with-rb-extension branch November 29, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@alexcrocha alexcrocha Awaiting requested review from alexcrocha alexcrocha is a code owner automatically assigned from Shopify/ruby-dx

Assignees
No one assigned
Labels
bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename and references fail if there's a directory using the rb extension
2 participants
@rogancodes @vinistock