Avoid directly calling version to avoid Sorbet error #2663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This will avoid breaking add-ons that don't define a
version
method and doesn't requireruby-lsp
as a dependency when displaying the add-ons in the UI.Implementation
Checks if the
version
method's owner ifAddon
. If it is, calling it would cause Sorbet to raise error so we avoid it. But if it's not, we call it to get the version.Automated Tests
Updated existing test to cover both cases (defined and not defined).
Manual Tests