Index global variables #2656
Merged
Index global variables #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
enhancement
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vinistock
reviewed
Oct 4, 2024
vinistock
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Iteration of #2644
Before providing features related to global variables, we must index them via RBS declarations, as we do for core constants for example.
Implementation
Handle
RBS::AST::Declarations::GlobalinRBSIndexer, and createEntry::GlobalVariablefor each declaration.Automated Tests
I added a basic test, following
index_methodsexample, but if specific assertions are required, I can add them.Manual Tests
After indexation process, a search in the index with
.prefix_search("$"), it should return all entries from RBS declaration.