Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid 'puts' in addons example #2616

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Avoid 'puts' in addons example #2616

merged 1 commit into from
Sep 24, 2024

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Sep 24, 2024

Using puts can break the LSP client/server connection.

Using `puts` can break the LSP client/server connection.
@andyw8 andyw8 added the chore Chore task label Sep 24, 2024
@andyw8 andyw8 requested a review from a team as a code owner September 24, 2024 19:53
@andyw8 andyw8 requested review from st0012 and vinistock September 24, 2024 19:53
@Earlopain
Copy link
Contributor

Should be fine since #2514?

@andyw8
Copy link
Contributor Author

andyw8 commented Sep 24, 2024

Should be fine since #2514?

It should be but we want this to match with an upcoming blog post about the add-on system.

@andyw8 andyw8 merged commit 8501f5e into main Sep 24, 2024
36 checks passed
@andyw8 andyw8 deleted the andyw8/avoid-puts branch September 24, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants