Address issue #2604 #2605
Closed
Address issue #2604 #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Sep 24, 2024
Closes Shopify#2604 Alternative to Shopify#2605 This moves the two command CI checks into the test suite. They would have cought this error, _expect_ rubocop is available to these. So, create a seperate Gemfile that contains only the gem itself.
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Sep 24, 2024
Closes Shopify#2604 Alternative to Shopify#2605 This moves the two command CI checks into the test suite. They would have cought this error, _expect_ rubocop is available to these. So, create a seperate Gemfile that contains only the gem itself. Co-authored-by: Theodore Liu <theodoretliu@gmail.com>
Earlopain
added a commit
to Earlopain/ruby-lsp
that referenced
this pull request
Sep 24, 2024
Closes Shopify#2604 Alternative to Shopify#2605 This moves the two command CI checks into the test suite. They would have cought this error, _expect_ rubocop is available to these. So, create a seperate Gemfile that contains only the gem itself. Co-authored-by: Theodore Liu <theodoretliu@gmail.com>
|
Thank you for the PR! I put up #2610 to address the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Proposed fix for #2604 . Also running into the same issue today.
Implementation
Follows the loading implementation present in
rubocop_runner.rbAutomated Tests
Untested!
Manual Tests
Seeing
Rubocopload error before change. Afterwards, LSP features start working again!