Fix bundler env #2595
Merged
Fix bundler env #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've signed the CLA! |
vinistock
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Thank you for the PR! We definitely missed this.
We should add a test for this to prevent regression. This test isn't exactly the same, but it also mutates project specific Bundler settings.
Can we please add a test case that configures any Bundler setting as an array so that we can confirm that the environment is mutated properly?
vinistock
added
server
epoberezhny
force-pushed
the
fix_bundler_env
branch
from
34c23e3 to
1d04d02
Compare
vinistock
approved these changes
Sep 23, 2024
epoberezhny
force-pushed
the
fix_bundler_env
branch
2 times, most recently
from
219eb88 to
82e4077
Compare
vinistock
reviewed
Sep 23, 2024
epoberezhny
force-pushed
the
fix_bundler_env
branch
from
82e4077 to
c6b5721
Compare
vinistock
approved these changes
Sep 23, 2024
Thank you for creating Ruby LSP and quick responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bundler has array configs like
BUNDLE_WITHOUTandsettings[e]returns array that later converted to string incorrectly (e.g.'[:development, :test]', but must be'development:test'). Because of that bundler tries to install all gems in Gemfile, whenruby-lspis not included in your application's GemfileImplementation
Automated Tests
Couldn't find any related tests, so tests are missing.
Manual Tests
You need to have a group of gems in your Gemfile. Then you should run
bundle config set without 'YOUR_GROUP'. And you should not have gems in this group installed after the LSP server starts