Turn on semantic highlighting for ERB #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
andyw8
approved these changes
Sep 12, 2024
|
There shouldn't be. Our ERB scanner separates the embedded Ruby from the host language, regardless of what the host language is. |
| @@ -39,7 +39,7 @@ class << self | |||
| sig { returns(Interface::SemanticTokensRegistrationOptions) } | |||
| def provider | |||
| Interface::SemanticTokensRegistrationOptions.new( | |||
| document_selector: [{ language: "ruby" }], | |||
| document_selector: [{ language: "ruby" }, { language: "erb" }], | |||
There was a problem hiding this comment.
Should this also have , { language: "eruby" } for the (Neo)vim crowd?
There was a problem hiding this comment.
The last time we tried turning ERB on for NeoVim, some limitations were identified #2432 (comment).
Someone would need to confirm if NeoVim is properly respecting the server's returned document selector and then we can make the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed semantic highlighting was turned off for ERB files. We should turn it on to get proper highlighting, especially in blocks with arguments.
For example, the
userusage below was not properly highlighted, but after this change it is.