Return semantic tokens for local vars shadowed by parameters #2509
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was an oversight from by part in #2482. There's still one scenario where we don't want to avoid returning local variable tokens for all assignment types: when the variable is being shadowed by a parameter.
For example
Implementation
Essentially, I brought back all of the methods removed in #2482, but now we only return tokens if the variable has been shadowed by a parameter.
Automated Tests
Added a fixture and expectation that captures all cases.