Consider that the project has a type checker if sorbet-static is present as transitive dependency
#2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esent as transitive dependency
vinistock
added
bugfix
|
I was curious if any gems had https://rubygems.org/gems/sorbet-static/reverse_dependencies |
andyw8
approved these changes
Aug 14, 2024
st0012
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm not sure how exactly we regressed on this, but we were again checking for a direct dependency on
sorbet-staticto determine if the application is using Sorbet. This is not the appropriate check because the direct dependency could be onsorbet-static-and-runtimeand we would then show duplicate features (which is currently happening).Implementation
Moved back to checking for
sorbet-staticin transitive dependencies.Automated Tests
Added a test that fails with the current implementation in main.