Fix extracting a method without another declaration to anchor replacement #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
KaanOzkan
approved these changes
Aug 19, 2024
vinistock
force-pushed
the
vs-fix-extract-method-on-script
branch
from
3539d76 to
86130e7
Compare
st0012
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2393
Currently, if someone tries to extract a selection into a method and there are no other methods in the same file, we don't file any node to anchor the selection (we end up finding a program node).
We need to account for this possibility to avoid breaking.
Implementation
When we don't have another method to anchor the replacement, there's not much that we can use to find a spot. So I went with the line immediately above the selection. The extracted source is slightly different, because we normally extract the method to a position below the selected one, but in this case we want to extract it above it.
Automated Tests
Added a test that reproduces the issue.