Use window log messages instead of printing to stderr #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
andyw8
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2057
This PR adds some extra logging to our automatic detections and gets rid of most
$stderr.putsusages in the code (in tests it's fine).We should always use
window/logMessagewhen showing some trace to the user, which allows us to set the type and follows the specification.The only remaining usages of puts are in the indexer, which I will follow up with another PR to get rid of.
Implementation
Added a convenience method to create log messages and started using it everywhere instead of printing.
As an added benefit, this PR forces us to separate presentation from logic instead of just putting puts everywhere.
Automated Tests
Made a few adjustments to the server test to make it more robust.