Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Index#index_all index rbs files too #2353

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Make Index#index_all index rbs files too #2353

merged 2 commits into from
Jul 24, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 24, 2024 •
edited
Loading

Motivation

  1. Since RBS indexing isn't optional, index_all should index RBS files too so the name is not misleading.
  2. The --time-index flag tracks the time taken to index all but not rbs files. Making index_all index rbs files too will make the flag more accurate.
    • Before: 
      Ruby LSP v0.17.10: Indexing took 1.46249 seconds and generated:
- Accessor: 3024
- Class: 2633
- Constant: 1819
- InstanceVariable: 6701
- Method: 18875
- Module: 2376
- SingletonClass: 796
- UnresolvedAlias: 155
- UnresolvedMethodAlias: 898
    • After: 
      Ruby LSP v0.17.10: Indexing took 1.66698 seconds and generated:
- Accessor: 3024
- Class: 2746
- Constant: 1819
- InstanceVariable: 6701
- Method: 20893
- Module: 2408
- SingletonClass: 833
- UnresolvedAlias: 155
- UnresolvedMethodAlias: 898

Implementation

Automated Tests

Manual Tests

@st0012 st0012 requested a review from a team as a code owner July 24, 2024 16:47
@st0012 st0012 requested review from andyw8 and vinistock July 24, 2024 16:47
@st0012 st0012 added chore Chore task server This pull request should be included in the server gem's release notes labels Jul 24, 2024
@st0012 st0012 self-assigned this Jul 24, 2024
st0012 added 2 commits July 24, 2024 18:27
@st0012
Make Index#index_all index rbs files too
1081a9a 
1. Since RBS indexing isn't optional, `index_all` should index RBS files too
   so the name is not misleading.
2. The `--time-index` flag tracks the time taken to index all files but
   not rbs files. Making `index_all` index rbs files too will make the
   flag more accurate.
@st0012
Sort --time-index's entries type list for easier comparison
ff1a14f
@st0012 st0012 force-pushed the make-index-all-index-all branch from 78a305d to ff1a14f Compare July 24, 2024 17:40
@st0012 st0012 requested a review from vinistock July 24, 2024 17:41
@st0012 st0012 merged commit 7885527 into main Jul 24, 2024
35 checks passed
@st0012 st0012 deleted the make-index-all-index-all branch July 24, 2024 18:06
@st0012 st0012 removed the chore Chore task label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@vinistock vinistock vinistock approved these changes

Assignees

@st0012 st0012

Labels
server This pull request should be included in the server gem's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st0012 @andyw8 @vinistock