Migrate indexing configuration to editor settings #2300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2156
Deprecate our
.index.yml
file and move to relying on editor settings instead. Editor settings are better suited for configuring language servers, rather than using custom configuration files.Editor settings already handle different levels of hierarchy. For example, workspace settings and user settings - merging when appropriate. In addition to that, we can show descriptions and examples of settings, which provide a much more intuitive experience. Overall, a custom configuration file is just a worse experience for the users.
A small caveat is that, because editor settings are usually camel case and we use snake case in Ruby, we need to accept both. This is what the settings look like now:
Implementation
.index.yml
initializationOptions
Automated Tests
Changed some tests.