Check if error data is present before using it #2293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #2285, I made a mistake an didn't check for
error.data
before using it. Thatcatch
statement may rescue more than just server error. For example, if we try to send a request when the connection has already been disposed, then we'll land on thatcatch
, but thedata
attribute won't exist, which would then try to read it and throw another error.Implementation
Made two changes:
data
is there before accessing it