Ensure test group exists before trying to add examples #2275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes another error found in our telemetry. We are sometimes getting test example code lens that are associated to a
group_id
for a group that doesn't exist.It's difficult to figure out exactly in what scenario this happens, but given that addons can contribute test code lens, we should protect the extension from invalid data anyway.
Implementation
We still had code in the test controller to account for the previous behaviour of code lens, which didn't include group IDs. It's been a long time since we released that, so I think it's safe to remove at this point. If anyone reports issues related to very old server versions, we can just ask them to update.
Other than simplifying the code after removing that old code lens handling, the fix is simply the check that the group exists before trying to add children. Otherwise, we print an error to the output channel.
Automated Tests
Created a test for the test controller, which was missing.