Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require space for class keyword match #2270

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Require space for class keyword match #2270

merged 1 commit into from
Jul 8, 2024

Conversation

vinistock
Copy link
Member

Motivation

Closes #2269

In order for class to be a keyword, there needs to be a space between it and the constant name.

Implementation

Switched to \s+ rather than \s*.

@vinistock vinistock added bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes labels Jul 8, 2024
@vinistock vinistock self-assigned this Jul 8, 2024
@vinistock vinistock requested a review from a team as a code owner July 8, 2024 20:47
@vinistock vinistock requested review from andyw8 and st0012 July 8, 2024 20:47
@vinistock vinistock mentioned this pull request Jul 8, 2024
Closed
st0012
st0012 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fast 👍

@vinistock vinistock enabled auto-merge (squash) July 8, 2024 20:59
@vinistock vinistock merged commit 6dfc884 into main Jul 8, 2024
35 checks passed
@vinistock vinistock deleted the vs/fix_class_keyword_match branch July 8, 2024 21:01
@andyw8
Copy link
Contributor

andyw8 commented Jul 8, 2024

This should apply to module on line 83 too?

@andyw8
Copy link
Contributor

andyw8 commented Jul 8, 2024

(although less likely to be encountered)

@vinistock vinistock mentioned this pull request Jul 9, 2024
Merged
@vinistock
Copy link
Member Author

@andyw8 good point, we should fix that too #2271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

@andyw8 andyw8 Awaiting requested review from andyw8 andyw8 is a code owner automatically assigned from Shopify/ruby-dx

Assignees

@vinistock vinistock

Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby Syntax Highlighting "class" where not actually a class i.e. "classification"
3 participants
@vinistock @andyw8 @st0012