Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run task command #2231

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Add run task command #2231

merged 1 commit into from
Jul 2, 2024

Conversation

vinistock
Copy link
Member

Motivation

Add a run task command so that addons can associate code lens command to be executed. This will allow us to add code lens for Rails generators or tasks, which all have different commands.

Implementation

Added a convenience execute method to Workspace. In the command, we try to get the currently active workspace. If we can't, we show the workspace quick pick. And then we run the command in it.

@vinistock vinistock added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes labels Jun 27, 2024
@vinistock vinistock self-assigned this Jun 27, 2024
@vinistock vinistock requested a review from a team as a code owner June 27, 2024 20:58
@vinistock vinistock requested a review from st0012 June 27, 2024 20:58
@vinistock vinistock force-pushed the vs/add_run_task_command branch from df86afa to 7c860da Compare June 27, 2024 21:05
@vinistock vinistock merged commit 6f37479 into main Jul 2, 2024
33 checks passed
@vinistock vinistock deleted the vs/add_run_task_command branch July 2, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants