Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move experimental features into global state #2209

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

vinistock
Copy link
Member

Motivation

The experimental features flag should be a part of the global state, so that every listener and addon can reuse it.

Implementation

Moved the experimental flag from Store to GlobalState. We don't have any experimental features right now, so nothing was using it.

Automated Tests

Added tests.

@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Jun 19, 2024
@vinistock vinistock self-assigned this Jun 19, 2024
@vinistock vinistock requested a review from a team as a code owner June 19, 2024 20:08
@vinistock vinistock requested review from andyw8 and st0012 June 19, 2024 20:08
@vinistock vinistock merged commit a782ea7 into main Jun 20, 2024
36 checks passed
@vinistock vinistock deleted the vs/move_exp_features_into_global_state branch June 20, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants