Lazily resolve method aliases #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
andyw8
approved these changes
Jun 18, 2024
vinistock
force-pushed
the
vs/lazily_resolve_method_aliases
branch
from
e7a7f61 to
8c63345
Compare
vinistock
force-pushed
the
vs/lazily_resolve_method_aliases
branch
from
8c63345 to
f193ecb
Compare
vinistock
added
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1940
This PR starts lazily resolving method aliases, so that we can show the correct information for aliases in definition, hover, completion and signature help.
Implementation
The idea is quite similar to constant aliases. If we encounter an unresolved entry, we try to resolve it recursively (since an alias can point to another alias). Then we store the resolved entry in the index so that we don't have to do it next time.
Automated Tests
Added tests for the index and for all of the features.