Don't generate code lens for nested definitions #2067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When testing a test framework or plugin, it's common to have test methods inside test methods. This change ensures that the code lens is only generated for tests that will actually be run by the test runner, not for nested definitions.
Implementation
It tracks the depth of nested method definition nodes and returns early if the depth is greater than one level.
Automated Tests
I've added a test that ensures the code lens is generated for the outer test method but not the inner one.
Manual Tests
Write a test with a another test method inside
Confirm that code lens appears for
test_foo
but nottest_bar