Allow omitting patch in .ruby-version #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
commented
May 2, 2024
| @@ -99,46 +138,51 @@ export class Chruby extends VersionManager { | |||
| private async discoverRubyVersion(): Promise<RubyVersion> { | |||
| let uri = this.bundleUri; | |||
| const root = path.parse(uri.fsPath).root; | |||
| let version: string; | |||
There was a problem hiding this comment.
I noticed that we were unintentionally catching our custom error for invalid .ruby-version files on the same catch as the one intended for non-existing files.
That's incorrect. When we find a .ruby-version file, but the contents are invalid, we want to raise and not continue going up the directories.
st0012
reviewed
May 2, 2024
vinistock
force-pushed
the
vs/allow_omitting_patch_for_chruby
branch
from
8dce0be to
07bb07a
Compare
st0012
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1969
Allow omitting the patch part of the version in the
.ruby-versionfile. This is being formalized as part of the specification being discussed by rubygems, so we need to support it as well.Implementation
I split the two behaviours in separate methods. When the patch is omitted, we need to list all available directories, sort them descending and then try to find one that matches the version.
Automated Tests
Added a test.