Support attributes #1208
Merged
Support attributes #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Nov 24, 2023
vinistock
force-pushed
the
vs/index_attributes
branch
from
3fd19f6 to
ae6a2cc
Compare
Morriar
approved these changes
Nov 27, 2023
Morriar
reviewed
Nov 28, 2023
vinistock
force-pushed
the
vs/index_attributes
branch
from
85f7593 to
5672fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Step towards #899
Add support for indexing attributes and using those in features. Definition and hover work without modification, there are only minor modifications in completion and workspace symbol.
Implementation
Automated Tests
Added tests.