Support methods invoked on self #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Nov 20, 2023
| @@ -82,7 +85,7 @@ def markdown_from_index_entries(title, entries) | |||
| markdown_title = "```ruby\n#{title}\n```" | |||
| definitions = [] | |||
| content = +"" | |||
| entries.each do |entry| | |||
| Array(entries).each do |entry| | |||
There was a problem hiding this comment.
Interesting. This wasn't caught by Sorbet before?
There was a problem hiding this comment.
Oh, it might be a mistake I made splitting the commits. I think I included the signature change for this method in the wrong commit, separate from the code changes. Sorbet did identify that Array required Kernel.
vinistock
force-pushed
the
vs/support_methods_invoked_on_self
branch
from
d425972 to
1b640a2
Compare
Morriar
reviewed
Nov 21, 2023
vinistock
force-pushed
the
vs/support_methods_invoked_on_self
branch
from
1b640a2 to
63823e7
Compare
vinistock
force-pushed
the
vs/support_methods_invoked_on_self
branch
from
63823e7 to
d45ab4a
Compare
Morriar
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Big step towards #899
I got frustrated that we keep getting feedback about missing method support and powered through some basic implementations.
This PR adds support for
self(since the receiver is known)We are not taking inheritance into account yet, this is just a first step. The same ideas from this PR can be applied to singleton methods once #1113 is merged.
Then we'll just be missing inheritance and methods with unknown receivers.
Implementation
I recommend reviewing per commit. For the most part, all implementations just use
resolve_methodor check method owners when necessary.The only exception is workspace symbol. We were just not supporting the method kind, which completely implements the functionality.
Automated Tests
Added tests for all of these.