Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connected? method to runner client #565

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Add connected? method to runner client #565

merged 1 commit into from
Jan 29, 2025

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Jan 29, 2025 •
edited
Loading

Add a connected? method to RunnerClient, so that we can make checks without having to use is_a?.

I also made send_notification and make_request private. They were not supposed to be public in the first place.

@vinistock Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock self-assigned this Jan 29, 2025
@vinistock vinistock requested review from andyw8 and KaanOzkan January 29, 2025 13:50
@vinistock vinistock marked this pull request as ready for review January 29, 2025 13:51
@vinistock vinistock requested a review from a team as a code owner January 29, 2025 13:51
andyw8
andyw8 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's label as chore so it doesn't appear in the release notes (it has no impact on users).

@vinistock vinistock mentioned this pull request Jan 29, 2025
Merged
@vinistock vinistock added the chore Chore task label Jan 29, 2025
@vinistock vinistock merged commit 5c59f2f into main Jan 29, 2025
29 checks passed
@vinistock Graphite App
Copy link
Member Author

Merge activity

  • Jan 29, 9:01 AM EST: A user merged this pull request with Graphite.

@vinistock vinistock deleted the 01-29-add_connected_method_to_runner_client branch January 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 approved these changes

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan

Assignees

@vinistock vinistock

Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinistock @andyw8