fix: Add missing React 18 reconciler function #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This adds a missing
detachDeletedInstance
function to@remote-ui/react/reconciler
, which is invoked during React's clean up phase. Prior to this change you'd get an exception / broken app when a component is removed (like the example in the unit test of toggling an image component).I created a minimal repro case on codesandbox and this is what that looks like in action:
Other notes
react-reconciler
in PR #21039createRemoteReactComponent
-generated components seem to e classified as Host Components by the reconciler