Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize Ruby Version to .ruby-version #278

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

jenshenny
Copy link
Contributor

@jenshenny jenshenny commented Mar 26, 2024

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

Important

Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

  • .ruby-version file is present with the correct Ruby version defined
  • A required_ruby_version in your gemspec is set
  • There is no Ruby version present in the dev.yml Ruby task (before: - ruby: x.x.x, after: - ruby)
  • There is no Ruby version/requirement referenced in the Gemfile (no lines with ruby <some-version>)
  • A Gemfile.lock is built with the defined Ruby version
  • The version of Rubocop installed is 1.61.0 or greater
  • There is no TargetRubyVersion defined in rubocop.yml (reads from required_ruby_version on Rubocop 1.61.0)
  • There is no Ruby argument present in ruby/setup-ruby Github Actions that do not run on a Ruby matrix (no lines with ruby-version: “x.x”)

Please merge this PR if it looks good, this PR will be merged if there isn't any activity after 4 weeks.

the version in dev.yml will be read from this file
it will read from required_ruby_version in RuboCop 1.61+
@jenshenny jenshenny requested a review from a team as a code owner March 26, 2024 21:01
@jenshenny jenshenny requested review from andyw8 and st0012 March 26, 2024 21:01
@andyw8 andyw8 merged commit 4b18157 into main Mar 26, 2024
10 checks passed
@andyw8 andyw8 deleted the centralize_ruby_version branch March 26, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants