Merge pull request #402 from Shopify/at-fix-parse

Do not raise unnecessarily during parsing
Shopify · Jan 21, 2025 · b16c86e · b16c86e
2 parents aca32f2 + 0038e4c
commit b16c86e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 45 deletions.
diff --git a/lib/rbi/parser.rb b/lib/rbi/parser.rb
@@ -451,11 +451,6 @@ def visit_call_node(node)
                 loc: node_loc(node),
                 comments: node_comments(node),
               )
-            else
-              raise ParseError.new(
-                "Unexpected token `#{node.message}` before `#{last_node&.string&.strip}`",
-                node_loc(node),
-              )
             end
           else
             current_scope << parse_visibility(node.name.to_s, node)
@@ -722,8 +717,6 @@ def parse_struct(node)
 
                 keyword_init = val == "true" if key == "keyword_init:"
               end
-            else
-              raise ParseError.new("Unexpected node type `#{arg.class}`", node_loc(arg))
             end
           end
         end

diff --git a/test/rbi/parser_test.rb b/test/rbi/parser_test.rb
@@ -1019,44 +1019,6 @@ def foo(
       RBI
     end
 
-    def test_parse_errors
-      e = assert_raises(ParseError) do
-        Parser.parse_string(<<~RBI)
-          def bar
-        RBI
-      end
-      assert_equal(
-        "unexpected end-of-input, assuming it is closing the parent top level context. expected an `end` " \
-          "to close the `def` statement.",
-        e.message,
-      )
-      assert_equal("-:1:7", e.location.to_s)
-
-      e = assert_raises(ParseError) do
-        Parser.parse_string(<<~RBI)
-          private include Foo
-        RBI
-      end
-      assert_equal("Unexpected token `private` before `include Foo`", e.message)
-      assert_equal("-:1:0-1:19", e.location.to_s)
-
-      e = assert_raises(ParseError) do
-        Parser.parse_string(<<~RBI)
-          private class Foo; end
-        RBI
-      end
-      assert_equal("Unexpected token `private` before `class Foo; end`", e.message)
-      assert_equal("-:1:0-1:22", e.location.to_s)
-
-      e = assert_raises(ParseError) do
-        Parser.parse_string(<<~RBI)
-          private CST = 42
-        RBI
-      end
-      assert_equal("Unexpected token `private` before `CST = 42`", e.message)
-      assert_equal("-:1:0-1:16", e.location.to_s)
-    end
-
     def test_parse_strings
       trees = Parser.parse_strings([
         "class Foo; end",