Merge pull request #2016 from Shopify/test-typing-import-matchers

Enable/fix test typing in multiple packages
Shopify · Sep 10, 2021 · f96703c · f96703c
2 parents 168986a + 4c12ed6
commit f96703c
Show file tree

Hide file tree

Showing 23 changed files with 87 additions and 24 deletions.
diff --git a/config/typescript/matchers.d.ts b/config/typescript/matchers.d.ts
@@ -0,0 +1,30 @@
+import {ComponentType, Context as ReactContext} from 'react';
+import type {} from 'saddle-up/matchers';
+import type {} from 'saddle-up/koa-matchers';
+
+// @shopify/react-testing/matchers
+declare type PropsFromNode<T> = T extends Node<infer U> ? U : never;
+declare global {
+  // eslint-disable-next-line @typescript-eslint/no-namespace
+  namespace jest {
+    interface Matchers<R, T = {}> {
+      toHaveReactProps(props: Partial<PropsFromNode<T>>): void;
+      toHaveReactDataProps(data: {[key: string]: string}): void;
+      toContainReactComponent<Type extends string | ComponentType<any>>(
+        type: Type,
+        props?: Partial<PropsFor<Type>>,
+      ): void;
+      toContainReactComponentTimes<Type extends string | ComponentType<any>>(
+        type: Type,
+        times: number,
+        props?: Partial<PropsFor<Type>>,
+      ): void;
+      toProvideReactContext<Type>(
+        context: ReactContext<Type>,
+        value?: Type,
+      ): void;
+      toContainReactText(text: string): void;
+      toContainReactHtml(text: string): void;
+    }
+  }
+}
diff --git a/packages/react-app-bridge-universal-provider/CHANGELOG.md b/packages/react-app-bridge-universal-provider/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.5 - 2021-08-30
 

diff --git a/packages/react-app-bridge-universal-provider/tsconfig.json b/packages/react-app-bridge-universal-provider/tsconfig.json
@@ -10,6 +10,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../react-html"}]
 }
diff --git a/packages/react-compose/CHANGELOG.md b/packages/react-compose/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.3 - 2021-08-24
 

diff --git a/packages/react-compose/tsconfig.json b/packages/react-compose/tsconfig.json
@@ -10,6 +10,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../useful-types"}]
 }
diff --git a/packages/react-cookie/CHANGELOG.md b/packages/react-cookie/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 1.1.5 - 2021-08-30
 

diff --git a/packages/react-cookie/tsconfig.json b/packages/react-cookie/tsconfig.json
@@ -11,6 +11,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../react-hooks"}, {"path": "../react-network"}]
 }
diff --git a/packages/react-csrf-universal-provider/CHANGELOG.md b/packages/react-csrf-universal-provider/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.5 - 2021-08-30
 

diff --git a/packages/react-csrf-universal-provider/tsconfig.json b/packages/react-csrf-universal-provider/tsconfig.json
@@ -10,7 +10,6 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [
     {"path": "../react-csrf"},
     {"path": "../react-effect"},

diff --git a/packages/react-csrf/CHANGELOG.md b/packages/react-csrf/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.3 - 2021-08-24
 

diff --git a/packages/react-csrf/tsconfig.json b/packages/react-csrf/tsconfig.json
@@ -9,6 +9,5 @@
     "../../config/typescript/*.d.ts",
     "./src/**/*.ts",
     "./src/**/*.tsx"
-  ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"]
+  ]
 }
diff --git a/packages/react-google-analytics/CHANGELOG.md b/packages/react-google-analytics/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 4.1.5 - 2021-08-30
 

diff --git a/packages/react-google-analytics/tsconfig.json b/packages/react-google-analytics/tsconfig.json
@@ -10,6 +10,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../react-import-remote"}]
 }
diff --git a/packages/react-hydrate/CHANGELOG.md b/packages/react-hydrate/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.4 - 2021-08-30
 

diff --git a/packages/react-hydrate/tsconfig.json b/packages/react-hydrate/tsconfig.json
@@ -10,6 +10,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../react-effect"}, {"path": "../react-hooks"}]
 }
diff --git a/packages/react-i18n-universal-provider/CHANGELOG.md b/packages/react-i18n-universal-provider/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.10 - 2021-09-03
 

diff --git a/packages/react-i18n-universal-provider/tsconfig.json b/packages/react-i18n-universal-provider/tsconfig.json
@@ -10,7 +10,6 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [
     {"path": "../react-effect"},
     {"path": "../react-hooks"},

diff --git a/packages/react-intersection-observer/CHANGELOG.md b/packages/react-intersection-observer/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 3.1.3 - 2021-08-24
 

diff --git a/packages/react-intersection-observer/tsconfig.json b/packages/react-intersection-observer/tsconfig.json
@@ -9,6 +9,5 @@
     "../../config/typescript/*.d.ts",
     "./src/**/*.ts",
     "./src/**/*.tsx"
-  ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"]
+  ]
 }
diff --git a/packages/react-tracking-pixel/CHANGELOG.md b/packages/react-tracking-pixel/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 4.1.5 - 2021-08-30
 

diff --git a/packages/react-tracking-pixel/tsconfig.json b/packages/react-tracking-pixel/tsconfig.json
@@ -10,6 +10,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../react-html"}]
 }
diff --git a/packages/react-universal-provider/CHANGELOG.md b/packages/react-universal-provider/CHANGELOG.md
@@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-<!-- ## Unreleased -->
+## Unreleased
+
+### Changed
+
+- Enable type checking in tests and fix type errors. [[#2011](https://github.com/Shopify/quilt/pull/2016)]
 
 ## 2.1.5 - 2021-08-30
 

diff --git a/packages/react-universal-provider/tsconfig.json b/packages/react-universal-provider/tsconfig.json
@@ -10,6 +10,5 @@
     "./src/**/*.ts",
     "./src/**/*.tsx"
   ],
-  "exclude": ["**/test/**/*", "**/tests/**/*"],
   "references": [{"path": "../react-effect"}, {"path": "../react-html"}]
 }