This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Fix issue #171 #202
Closed
Fix issue #171 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue is due to the plugin treating an HtmlRawNode as preformatted text not to be touched the moment it detects the ` character (for template literals) anywhere in the body. Aside from not formatting the contents, it doesn't strip the leading and trailing newlines resulting in compounding new lines everytime prettier is run against the file. This fixes the compounding line issue in particular but does not fix the contents not being prettified when a ` is detected anywhere in the text.
|
Moving to https://github.com/Shopify/theme-tools, please re-open there if still relevant! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is due to the plugin treating an HtmlRawNode as preformatted text not to be touched the moment it detects the ` character (for template literals) anywhere in the body. Aside from not formatting the contents, it doesn't strip the leading and trailing newlines resulting in compounding new lines everytime prettier is run against the file. This fixes the compounding line issue in particular but does not fix the contents not being prettified when a ` is detected anywhere in the text.