Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Support the network layer in IE9 #58

Merged
merged 2 commits into from
Mar 30, 2016
Merged

Conversation

minasmart
Copy link
Contributor

Depends on: https://github.com/Shopify/shopify/pull/68257

Uses XDRs with special authorization for special IE9, since CORS is not supported through XHR in that environment.

NOTE: IE9 has very limited error handling and debugging capability with this approach. This constitutes a bare minimum of functionality.

OTHER NOTE: This does not fix mixed schemes. At this point, IE9 will have to be supported on https scheme websites only. Fixing this caveat requires work in Shopify Core, and does not constitute a release.

@minasmart
Copy link
Contributor Author

CC: @richgilbank @tessalt

@tessalt
Copy link
Contributor

tessalt commented Mar 29, 2016

very cool. And by cool I mean IE9 is terrible, but gj.

@richgilbank
Copy link
Contributor

@minasmart minasmart merged commit 3d46d53 into master Mar 30, 2016
@minasmart minasmart deleted the ie9-cors-support branch March 30, 2016 14:27
@minasmart minasmart temporarily deployed to production March 30, 2016 14:48 Inactive
mikkoh pushed a commit that referenced this pull request Oct 12, 2016
[FIX] Support the network layer in IE9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants