Adjust total time for failed jobs #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that total_time is updated even when a job has failed. Previously, total_time would not include the run-time of the iteration that failed.
emily827
force-pushed
the
el/always_adjust_total_time
branch
from
39fb7c8 to
d93275a
Compare
solackerman
approved these changes
Feb 22, 2023
I think that's because the main branch is failing 🤔 Those failures don't look related to my changes I think - #339 and steveklabnik/mono_logger#12 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
total_timeis always going to be updated, even when a job fails.Previously, if a job failed,
total_timewould not include the run-time of the iteration that threw the exception.Motivation
We want to create a metric to keep track of a job's total run-time. This metric is going to be reported whenever a job completes successfully, fails, or is interrupted