Fetching data docs (rfc) #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blittle
reviewed
Dec 12, 2022
|
|
||
| return defer({ | ||
| product: await productQuery, | ||
| reviews: reviewsQuery, |
There was a problem hiding this comment.
Should this example also include how to consume the deferred data from useLoaderData()?
blittle
reviewed
Dec 12, 2022
| id | ||
| title | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe a better example of something you wouldn't want to cache would be cart? Realistically I would think product id and title would be cached for long.
blittle
approved these changes
Dec 12, 2022
This was referenced Dec 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from #58 and #131 . We never merged those PRs and the code has changed quite a lot since then.
I've removed the mentions to the
filterutility since we haven't implemented it.