Fix getProductOption from crashing when one of the optionValues doesn't return a firstSelectableVariant
#2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
wizardlyhel
changed the title
firstSelectableVariant
wizardlyhel
changed the title
firstSelectableVariantgetProductOption from crashing when one of the optionValues doesn't return a firstSelectableVariant
rbshop
reviewed
Jan 13, 2025
Comment on lines
+243
to
+246
| // It is possible for firstSelectableVariant to be null | ||
| firstOptionValues = product.options[0].optionValues.filter( | ||
| (value) => !!value?.firstSelectableVariant, | ||
| )[0]; |
There was a problem hiding this comment.
I believe this should happen before the above !firstOptionValues?.name check, otherwise we're potentially ending up with an option value without a name
There was a problem hiding this comment.
firstOptionValues is assigned as the first item in product.options[0].optionValues on line 236
Line 243-246 is just reassigning firstOptionValues to ensure it returns an option value that has a firstSelectableVariant defined
rbshop
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #2698
On a very rare occasion,
optionValues.firstSelectableVariantmay returnnull.WHAT is this pull request doing?
Make sure
getProductOptionhandles well if encountered a nullfirstSelectableVariant.HOW to test your changes?
Post-merge steps
Checklist