Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 2k variant, combined listing usage with getProductOptions #2659

Merged
merged 24 commits into from
Dec 10, 2024
Merged

Support 2k variant, combined listing usage with getProductOptions #2659

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
256cd25
getProductOptions
wizardlyhel Nov 28, 2024
68dd48f
tests and helper functions
wizardlyhel Nov 29, 2024
3e40ea4
more test
wizardlyhel Nov 29, 2024
fe6f8ce
lint
wizardlyhel Nov 29, 2024
5ddc8fb
Clean up
wizardlyhel Dec 3, 2024
8a11fd3
add one more test
wizardlyhel Dec 3, 2024
1dd7a59
Replace product form
wizardlyhel Dec 3, 2024
da91cfa
comments
wizardlyhel Dec 3, 2024
3a67d05
more comments
wizardlyhel Dec 3, 2024
4ec0a8f
docs
wizardlyhel Dec 4, 2024
6e23e6d
more docs
wizardlyhel Dec 4, 2024
d463bae
docs
wizardlyhel Dec 4, 2024
b36ea1f
update b2b example
wizardlyhel Dec 4, 2024
bbc91c8
fix generated types
wizardlyhel Dec 4, 2024
a69de5d
Fix test
wizardlyhel Dec 4, 2024
2b94045
add changeset
wizardlyhel Dec 4, 2024
99645ab
address feedbacks
wizardlyhel Dec 10, 2024
bc740e9
don't display single options
wizardlyhel Dec 10, 2024
24a0c90
lint, typecheck
wizardlyhel Dec 10, 2024
9caa0a4
update generated files
wizardlyhel Dec 10, 2024
b647021
update changeset instruction
wizardlyhel Dec 10, 2024
707988a
update dev docs
wizardlyhel Dec 10, 2024
b07f6dd
update package lock
wizardlyhel Dec 10, 2024
92a5342
update changelog
wizardlyhel Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions examples/b2b/storefrontapi.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,36 +252,6 @@ export type StoreRobotsQueryVariables = StorefrontAPI.Exact<{

export type StoreRobotsQuery = {shop: Pick<StorefrontAPI.Shop, 'id'>};

export type SitemapQueryVariables = StorefrontAPI.Exact<{
urlLimits?: StorefrontAPI.InputMaybe<StorefrontAPI.Scalars['Int']['input']>;
language?: StorefrontAPI.InputMaybe<StorefrontAPI.LanguageCode>;
}>;

export type SitemapQuery = {
products: {
nodes: Array<
Pick<
StorefrontAPI.Product,
'updatedAt' | 'handle' | 'onlineStoreUrl' | 'title'
> & {
featuredImage?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.Image, 'url' | 'altText'>
>;
}
>;
};
collections: {
nodes: Array<
Pick<StorefrontAPI.Collection, 'updatedAt' | 'handle' | 'onlineStoreUrl'>
>;
};
pages: {
nodes: Array<
Pick<StorefrontAPI.Page, 'updatedAt' | 'handle' | 'onlineStoreUrl'>
>;
};
};

export type FeaturedCollectionFragment = Pick<
StorefrontAPI.Collection,
'id' | 'title' | 'handle'
Expand Down Expand Up @@ -1256,10 +1226,6 @@ interface GeneratedQueryTypes {
return: StoreRobotsQuery;
variables: StoreRobotsQueryVariables;
};
'#graphql\n query Sitemap($urlLimits: Int, $language: LanguageCode)\n @inContext(language: $language) {\n products(\n first: $urlLimits\n query: "published_status:\'online_store:visible\'"\n ) {\n nodes {\n updatedAt\n handle\n onlineStoreUrl\n title\n featuredImage {\n url\n altText\n }\n }\n }\n collections(\n first: $urlLimits\n query: "published_status:\'online_store:visible\'"\n ) {\n nodes {\n updatedAt\n handle\n onlineStoreUrl\n }\n }\n pages(first: $urlLimits, query: "published_status:\'published\'") {\n nodes {\n updatedAt\n handle\n onlineStoreUrl\n }\n }\n }\n': {
return: SitemapQuery;
variables: SitemapQueryVariables;
};
'#graphql\n fragment FeaturedCollection on Collection {\n id\n title\n image {\n id\n url\n altText\n width\n height\n }\n handle\n }\n query FeaturedCollection($country: CountryCode, $language: LanguageCode)\n @inContext(country: $country, language: $language) {\n collections(first: 1, sortKey: UPDATED_AT, reverse: true) {\n nodes {\n ...FeaturedCollection\n }\n }\n }\n': {
return: FeaturedCollectionQuery;
variables: FeaturedCollectionQueryVariables;
Expand Down
190 changes: 149 additions & 41 deletions examples/custom-cart-method/storefrontapi.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,36 +254,6 @@ export type StoreRobotsQueryVariables = StorefrontAPI.Exact<{

export type StoreRobotsQuery = {shop: Pick<StorefrontAPI.Shop, 'id'>};

export type SitemapQueryVariables = StorefrontAPI.Exact<{
urlLimits?: StorefrontAPI.InputMaybe<StorefrontAPI.Scalars['Int']['input']>;
language?: StorefrontAPI.InputMaybe<StorefrontAPI.LanguageCode>;
}>;

export type SitemapQuery = {
products: {
nodes: Array<
Pick<
StorefrontAPI.Product,
'updatedAt' | 'handle' | 'onlineStoreUrl' | 'title'
> & {
featuredImage?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.Image, 'url' | 'altText'>
>;
}
>;
};
collections: {
nodes: Array<
Pick<StorefrontAPI.Collection, 'updatedAt' | 'handle' | 'onlineStoreUrl'>
>;
};
pages: {
nodes: Array<
Pick<StorefrontAPI.Page, 'updatedAt' | 'handle' | 'onlineStoreUrl'>
>;
};
};

export type FeaturedCollectionFragment = Pick<
StorefrontAPI.Collection,
'id' | 'title' | 'handle'
Expand Down Expand Up @@ -739,10 +709,81 @@ export type ProductVariantFragment = Pick<

export type ProductFragment = Pick<
StorefrontAPI.Product,
'id' | 'title' | 'vendor' | 'handle' | 'descriptionHtml' | 'description'
| 'id'
| 'title'
| 'vendor'
| 'handle'
| 'descriptionHtml'
| 'description'
| 'encodedVariantExistence'
| 'encodedVariantAvailability'
> & {
options: Array<Pick<StorefrontAPI.ProductOption, 'name' | 'values'>>;
selectedVariant?: StorefrontAPI.Maybe<
options: Array<
Pick<StorefrontAPI.ProductOption, 'name'> & {
optionValues: Array<
Pick<StorefrontAPI.ProductOptionValue, 'name'> & {
firstSelectableVariant?: StorefrontAPI.Maybe<
Pick<
StorefrontAPI.ProductVariant,
'availableForSale' | 'id' | 'sku' | 'title'
> & {
compareAtPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
image?: StorefrontAPI.Maybe<
{__typename: 'Image'} & Pick<
StorefrontAPI.Image,
'id' | 'url' | 'altText' | 'width' | 'height'
>
>;
price: Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>;
product: Pick<StorefrontAPI.Product, 'title' | 'handle'>;
selectedOptions: Array<
Pick<StorefrontAPI.SelectedOption, 'name' | 'value'>
>;
unitPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
}
>;
swatch?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.ProductOptionValueSwatch, 'color'> & {
image?: StorefrontAPI.Maybe<{
previewImage?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.Image, 'url'>
>;
}>;
}
>;
}
>;
}
>;
selectedOrFirstAvailableVariant?: StorefrontAPI.Maybe<
Pick<
StorefrontAPI.ProductVariant,
'availableForSale' | 'id' | 'sku' | 'title'
> & {
compareAtPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
image?: StorefrontAPI.Maybe<
{__typename: 'Image'} & Pick<
StorefrontAPI.Image,
'id' | 'url' | 'altText' | 'width' | 'height'
>
>;
price: Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>;
product: Pick<StorefrontAPI.Product, 'title' | 'handle'>;
selectedOptions: Array<
Pick<StorefrontAPI.SelectedOption, 'name' | 'value'>
>;
unitPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
}
>;
adjacentVariants: Array<
Pick<
StorefrontAPI.ProductVariant,
'availableForSale' | 'id' | 'sku' | 'title'
Expand Down Expand Up @@ -808,10 +849,81 @@ export type ProductQuery = {
product?: StorefrontAPI.Maybe<
Pick<
StorefrontAPI.Product,
'id' | 'title' | 'vendor' | 'handle' | 'descriptionHtml' | 'description'
| 'id'
| 'title'
| 'vendor'
| 'handle'
| 'descriptionHtml'
| 'description'
| 'encodedVariantExistence'
| 'encodedVariantAvailability'
> & {
options: Array<Pick<StorefrontAPI.ProductOption, 'name' | 'values'>>;
selectedVariant?: StorefrontAPI.Maybe<
options: Array<
Pick<StorefrontAPI.ProductOption, 'name'> & {
optionValues: Array<
Pick<StorefrontAPI.ProductOptionValue, 'name'> & {
firstSelectableVariant?: StorefrontAPI.Maybe<
Pick<
StorefrontAPI.ProductVariant,
'availableForSale' | 'id' | 'sku' | 'title'
> & {
compareAtPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
image?: StorefrontAPI.Maybe<
{__typename: 'Image'} & Pick<
StorefrontAPI.Image,
'id' | 'url' | 'altText' | 'width' | 'height'
>
>;
price: Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>;
product: Pick<StorefrontAPI.Product, 'title' | 'handle'>;
selectedOptions: Array<
Pick<StorefrontAPI.SelectedOption, 'name' | 'value'>
>;
unitPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
}
>;
swatch?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.ProductOptionValueSwatch, 'color'> & {
image?: StorefrontAPI.Maybe<{
previewImage?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.Image, 'url'>
>;
}>;
}
>;
}
>;
}
>;
selectedOrFirstAvailableVariant?: StorefrontAPI.Maybe<
Pick<
StorefrontAPI.ProductVariant,
'availableForSale' | 'id' | 'sku' | 'title'
> & {
compareAtPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
image?: StorefrontAPI.Maybe<
{__typename: 'Image'} & Pick<
StorefrontAPI.Image,
'id' | 'url' | 'altText' | 'width' | 'height'
>
>;
price: Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>;
product: Pick<StorefrontAPI.Product, 'title' | 'handle'>;
selectedOptions: Array<
Pick<StorefrontAPI.SelectedOption, 'name' | 'value'>
>;
unitPrice?: StorefrontAPI.Maybe<
Pick<StorefrontAPI.MoneyV2, 'amount' | 'currencyCode'>
>;
}
>;
adjacentVariants: Array<
Pick<
StorefrontAPI.ProductVariant,
'availableForSale' | 'id' | 'sku' | 'title'
Expand Down Expand Up @@ -1175,10 +1287,6 @@ interface GeneratedQueryTypes {
return: StoreRobotsQuery;
variables: StoreRobotsQueryVariables;
};
'#graphql\n query Sitemap($urlLimits: Int, $language: LanguageCode)\n @inContext(language: $language) {\n products(\n first: $urlLimits\n query: "published_status:\'online_store:visible\'"\n ) {\n nodes {\n updatedAt\n handle\n onlineStoreUrl\n title\n featuredImage {\n url\n altText\n }\n }\n }\n collections(\n first: $urlLimits\n query: "published_status:\'online_store:visible\'"\n ) {\n nodes {\n updatedAt\n handle\n onlineStoreUrl\n }\n }\n pages(first: $urlLimits, query: "published_status:\'published\'") {\n nodes {\n updatedAt\n handle\n onlineStoreUrl\n }\n }\n }\n': {
return: SitemapQuery;
variables: SitemapQueryVariables;
};
'#graphql\n fragment FeaturedCollection on Collection {\n id\n title\n image {\n id\n url\n altText\n width\n height\n }\n handle\n }\n query FeaturedCollection($country: CountryCode, $language: LanguageCode)\n @inContext(country: $country, language: $language) {\n collections(first: 1, sortKey: UPDATED_AT, reverse: true) {\n nodes {\n ...FeaturedCollection\n }\n }\n }\n': {
return: FeaturedCollectionQuery;
variables: FeaturedCollectionQueryVariables;
Expand Down Expand Up @@ -1223,7 +1331,7 @@ interface GeneratedQueryTypes {
return: PoliciesQuery;
variables: PoliciesQueryVariables;
};
'#graphql\n query Product(\n $country: CountryCode\n $handle: String!\n $language: LanguageCode\n $selectedOptions: [SelectedOptionInput!]!\n ) @inContext(country: $country, language: $language) {\n product(handle: $handle) {\n ...Product\n }\n }\n #graphql\n fragment Product on Product {\n id\n title\n vendor\n handle\n descriptionHtml\n description\n options {\n name\n values\n }\n selectedVariant: variantBySelectedOptions(selectedOptions: $selectedOptions, ignoreUnknownOptions: true, caseInsensitiveMatch: true) {\n ...ProductVariant\n }\n variants(first: 1) {\n nodes {\n ...ProductVariant\n }\n }\n seo {\n description\n title\n }\n }\n #graphql\n fragment ProductVariant on ProductVariant {\n availableForSale\n compareAtPrice {\n amount\n currencyCode\n }\n id\n image {\n __typename\n id\n url\n altText\n width\n height\n }\n price {\n amount\n currencyCode\n }\n product {\n title\n handle\n }\n selectedOptions {\n name\n value\n }\n sku\n title\n unitPrice {\n amount\n currencyCode\n }\n }\n\n\n': {
'#graphql\n query Product(\n $country: CountryCode\n $handle: String!\n $language: LanguageCode\n $selectedOptions: [SelectedOptionInput!]!\n ) @inContext(country: $country, language: $language) {\n product(handle: $handle) {\n ...Product\n }\n }\n #graphql\n fragment Product on Product {\n id\n title\n vendor\n handle\n descriptionHtml\n description\n encodedVariantExistence\n encodedVariantAvailability\n options {\n name\n optionValues {\n name\n firstSelectableVariant {\n ...ProductVariant\n }\n swatch {\n color\n image {\n previewImage {\n url\n }\n }\n }\n }\n }\n selectedOrFirstAvailableVariant(selectedOptions: $selectedOptions, ignoreUnknownOptions: true, caseInsensitiveMatch: true) {\n ...ProductVariant\n }\n adjacentVariants (selectedOptions: $selectedOptions) {\n ...ProductVariant\n }\n variants(first: 1) {\n nodes {\n ...ProductVariant\n }\n }\n seo {\n description\n title\n }\n }\n #graphql\n fragment ProductVariant on ProductVariant {\n availableForSale\n compareAtPrice {\n amount\n currencyCode\n }\n id\n image {\n __typename\n id\n url\n altText\n width\n height\n }\n price {\n amount\n currencyCode\n }\n product {\n title\n handle\n }\n selectedOptions {\n name\n value\n }\n sku\n title\n unitPrice {\n amount\n currencyCode\n }\n }\n\n\n': {
return: ProductQuery;
variables: ProductQueryVariables;
};
Expand Down
Loading
Loading