Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BuyerAuthentication] if shopId is passed, use the core url #2437

Merged
merged 5 commits into from
Sep 25, 2024
Merged

[BuyerAuthentication] if shopId is passed, use the core url #2437

merged 5 commits into from
Sep 25, 2024

Conversation

s-lee-kwong
Copy link
Contributor

@s-lee-kwong s-lee-kwong commented Aug 15, 2024 •
edited by wizardlyhel
Loading

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

HOW to test your changes?

  • Test on mock.shop
    • Make sure no errors in console until clicking on the sign in link
  • Test with a shop using new customer account
    • In .env, supply a PUBLIC_CUSTOMER_ACCOUNT_API_URL without SHOP_ID - This generate a warning message about the customer account update and that env.SHOP_ID is required

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

@s-lee-kwong s-lee-kwong self-assigned this Aug 15, 2024
@shopify Shopify
Copy link
Contributor

shopify bot commented Aug 15, 2024 •
edited
Loading

Oxygen deployed a preview of your slk/core-auth-in-prod branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
metaobjects ❌ Error (Logs) - Inspect deployment September 24, 2024 7:56 PM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:52 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment September 24, 2024 7:53 PM

Learn more about Hydrogen's GitHub integration.

@s-lee-kwong s-lee-kwong force-pushed the slk/core-auth-in-prod branch 2 times, most recently from 2871131 to 5219afe Compare August 15, 2024 16:54
@s-lee-kwong
Copy link
Contributor Author

/snapit

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @s-lee-kwong! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/mini-oxygen": "0.0.0-snapshot-20240815183308"

@s-lee-kwong
Copy link
Contributor Author

/snapit

@wizardlyhel wizardlyhel mentioned this pull request Aug 19, 2024
Closed
@wizardlyhel wizardlyhel marked this pull request as ready for review August 19, 2024 17:30
@wizardlyhel
Copy link
Contributor

/snapit

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@s-lee-kwong
Copy link
Contributor Author

/snapit

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @s-lee-kwong! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20240821120310",
"@shopify/hydrogen": "0.0.0-snapshot-20240821120310",
"@shopify/mini-oxygen": "0.0.0-snapshot-20240821120310"

Create a new project with all the released packages running npm create @shopify/hydrogen@<snapshot_version>
To try a new CLI plugin version, add @shopify/cli-hydrogen as a dependency to your project using the snapshot version.

@s-lee-kwong
Copy link
Contributor Author

/snapit

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @s-lee-kwong! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/cli-hydrogen": "0.0.0-snapshot-20240821132307",
"@shopify/hydrogen": "0.0.0-snapshot-20240821132307",
"@shopify/mini-oxygen": "0.0.0-snapshot-20240821132307"

Create a new project with all the released packages running npm create @shopify/hydrogen@<snapshot_version>
To try a new CLI plugin version, add @shopify/cli-hydrogen as a dependency to your project using the snapshot version.

s-lee-kwong
s-lee-kwong commented Aug 21, 2024
View reviewed changes
templates/skeleton/app/routes/account.orders.$id.tsx
Comment on lines +32 to +34

const fulfillmentStatus =
flattenConnection(order.fulfillments)[0]?.status ?? 'N/A';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this error when one doesn't have any fulfillments on an order

@s-lee-kwong s-lee-kwong force-pushed the slk/core-auth-in-prod branch 2 times, most recently from ae3dcb8 to 96cf026 Compare September 9, 2024 13:23
blittle
blittle approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tophatted with and without the new SHOP_ID. I still wish we could have kept the new variable matching the format of the existing variables.

@wizardlyhel wizardlyhel merged commit f336303 into main Sep 25, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the slk/core-auth-in-prod branch September 25, 2024 17:39
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blittle blittle blittle approved these changes

@wizardlyhel wizardlyhel wizardlyhel approved these changes

Assignees

@s-lee-kwong s-lee-kwong

Labels
2024.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s-lee-kwong @wizardlyhel @blittle @michenly