Avoid inlining small assets to fix CSP #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite inlines imported small assets (<4kb) by default. This creates issues with our favicon and the default CSP value, which does not allow
img-src data:.We could:
data:in the CSP.publicand start to prepend the[import.meta.env.BASE_PATHvariable](https://vitejs.dev/guide/build.html#public-base-path) manually in Remix'links.I'm opting for the last option here since it works for all the links in the app and doesn't introduce new unknown syntax for users.
Happy to change it though if something else makes more sense.
We could add this option to our CLI / plugins but I think it's better if the user has it in the config directly?