Improve predictive search performance #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
wizardlyhel
approved these changes
Mar 11, 2024
blittle
approved these changes
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predictive search API and components were making 3 requests for every key stroke: the actual API request + root revalidation + route revalidation:
I'm changing the Form method to
GEThere, which avoids unnecessary Remix revalidations. Plus, it gives us the opportunity to set Cache-Control headers in the response, which is useful when typing:Typing something new goes through, but typing the same thing just uses the browser cache for up to a minute.
We could also consider debouncing but it's probably OK with this?