Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GraphQL 1.6's multiplexed execution #55

Closed
wants to merge 1 commit into from

Conversation

theorygeek
Copy link

@theorygeek theorygeek commented Jun 6, 2017

In GraphQL 1.6, @rmosolgo introduced the Schema#multiplex feature 🎉 which lets you execute multiple queries in one go. But it seems that it invokes the query instrumentation once per query, instead of just once, which causes the NestedError to be raised. This change removes the NestedError behavior.

I'm opening this PR mainly as a discussion. I'm actually not sure what the ramifications are of allowing this nested behavior. But anywho, thoughts?

@rmosolgo
Copy link
Contributor

rmosolgo commented Jun 6, 2017

I was thinking this might need a tiny bit more change, that the instrumenter could be adjusted to hook on instrument(:multiplex, ...), that way, the single executor could be shared by all queries.

I'd be happy to take it for a spin this afternoon, I think a proper test calling Schema#multiplex would be a good way to ensure that it works properly.

@rmosolgo
Copy link
Contributor

rmosolgo commented Jun 6, 2017

Here's another take, what do you think?

#57

@theorygeek
Copy link
Author

@rmosolgo Ah nice, yeah I think that's a better solution than the one I have here.

@theorygeek theorygeek closed this Jun 7, 2017
@theorygeek theorygeek deleted the graphql-1.6 branch June 7, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants