fix: item separator with inverted flashlist #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's absurd that this is not merged yet. It's a very basic behavior and it's broken. |
|
@imranbarbhuiya Can you please sign the CLA so that this can be merged? |
I already signed, the CLA needs to be rerun to verify |
naqvitalha
approved these changes
Mar 13, 2024
|
e2e is failing in the main branch too so it seems unrelated to this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes the
ItemSeparatorComponentposition for theinvertedflashlist. Thanks to @mkhoussid for suggesting this fix. I tested in my app and it workedFixes (issue #)
fixes #638
Reviewers’ hat-rack 🎩
Screenshots or videos (if needed)
Checklist