This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
[typescript/prefer-pascal-case-enum] Fix an issue with undefined name #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandcote
commented
Jan 20, 2020
| @@ -8,7 +8,6 @@ const ruleTester = new RuleTester({ | |||
|
|
|||
| function errorWithName(name) { | |||
| return { | |||
| type: 'Identifier', | |||
There was a problem hiding this comment.
I had to remove this check because when the key is a string, the type of the error is Literal
cartogram
approved these changes
Feb 4, 2020
| @@ -8,7 +8,6 @@ const ruleTester = new RuleTester({ | |||
|
|
|||
| function errorWithName(name) { | |||
| return { | |||
| type: 'Identifier', | |||
alexandcote
force-pushed
the
fix_pascal_case
branch
2 times, most recently
from
573b02a to
d098e03
Compare
alexandcote
force-pushed
the
fix_pascal_case
branch
from
d098e03 to
15bbc15
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #516
valuewhen thenameisundefined. When the key of the enum is declared as a string, thenameisundefinedpascalCasefunction.You can find more context in the issue.