This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Revert Typescript update to fix prettier #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
changed the title
lemonmade
approved these changes
Apr 26, 2019
| "merge": "1.2.1", | ||
| "pascal-case": "^2.0.1", | ||
| "pkg-dir": "4.1.0", | ||
| "pluralize": "^7.0.0" | ||
| "pluralize": "^7.0.0", | ||
| "typescript-eslint-parser": "20.0.0" |
There was a problem hiding this comment.
Do you know what versions of TypeScript this supports?
There was a problem hiding this comment.
Yeah it should be on ~3.2.1, thanks for catching that.
There was a problem hiding this comment.
Actually, what I had was right. typescript-estree doesn't support past ~3.1.1.
| // parserOptions: { | ||
| // project: 'tsconfig.json', | ||
| // tsconfigRootDir: __dirname, | ||
| // }, |
cartogram
pushed a commit
that referenced
this pull request
Apr 26, 2019
* 'master' of github.com:Shopify/eslint-plugin-shopify: Revert Typescript update to fix prettier (#249)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the typescript updates from #233 because they break the vscode prettier plugin. Without these changes, vscode will not format code using prettier-eslint. The following error will display in the output: